feat: Add controls feature to tweak the visualizer easier #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isualizer/randomize-amplitude
…a-visualizer/add-emitter-tilting
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
9 tasks
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…-tilting' into feat/issues-1171-add-controls-for-visualizer # Conflicts: # client/src/features/visualizer-threejs/CameraControls.tsx
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
panteleymonchuk
changed the base branch from
dev
to
feat/nova-visualizer/add-emitter-tilting
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…nfigControls.tsx Co-authored-by: JCNoguera <[email protected]>
…nfigControls.tsx Co-authored-by: JCNoguera <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…-tilting' into feat/issues-1171-add-controls-for-visualizer # Conflicts: # client/src/features/visualizer-threejs/utils.ts
panteleymonchuk
force-pushed
the
feat/issues-1171-add-controls-for-visualizer
branch
from
a6991c3 to
cba1854
Compare
…-tilting' into feat/issues-1171-add-controls-for-visualizer
Base automatically changed from
feat/nova-visualizer/add-emitter-tilting
to
dev
February 26, 2024 16:37
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
Signed-off-by: Eugene Panteleymonchuk <[email protected]>
…ontrols-for-visualizer
begonaalvarezd
approved these changes
Feb 27, 2024
begonaalvarezd
deleted the
feat/issues-1171-add-controls-for-visualizer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
closes #1171
How the change has been tested
Enable feature
controlsVisualiserEnabledinVisualizerInstance. Select value that need to be changed and press "apply".Expected result:
Visualizer uses sat values.
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.